-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pegin tests integration #2895
Draft
julianlen
wants to merge
201
commits into
feature/powpeg_validation_protocol-integration
Choose a base branch
from
pegin-tests-integration
base: feature/powpeg_validation_protocol-integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Pegin tests integration #2895
julianlen
wants to merge
201
commits into
feature/powpeg_validation_protocol-integration
from
pegin-tests-integration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder rskip
Add tests Refactor Rename variable
Add key to storage index Remove declaration of svp fund tx hash since it is not being used yet. Remove _KEY suffix
Remove _KEY suffix. Save proposed federation the same way as pending one
Add proposedFederationIsSet logic Getting rid of proposedFederationIsSet logic. Add isProposedFederationSet logic. Add rskip419 check in saveProposedFederation method Save null version when proposed federation is null Remove unnecessary private method Refactor Removes null activations from tests
Make variable final Improve test name Use all activations instead of lovell Improve null handling
Add get proposed federation tests Minor fix after rebase Improve comment Minor refactor Minor refactor Improve comment Add test case Throw exception when there is no storage version for non-null proposed federation Add test cases Add log. Add test case and refactor Remove unused import
…sh methods and tests Rebases Reorders and renames tests Rebases Appends SVP prefix to FUND_TX_HASH_UNSIGNED and refactors tests Rebases Moves repeated arrange code to setup. Using Optional. Rebases Removes _ from the key Using arrowhead631 Rebases Rebases Renames saveFundTransactionUnsignedHash to saveSvpFundTransactionUnsignedHash Renames FundTransactionUnsignedHash instance fields
Remove unnecessary private method Refactor
Add get proposed federation tests Minor fix after rebase Improve comment Minor refactor Add test case
…d federation Add test cases Add log. Add test case and refactor Remove unused import
…sh methods and tests Rebases Moves repeated arrange code to setup. Using Optional. Rebases
Adds test to assert empty is returned when hash hasn't been set or saved Renames svp fields to match the RSKIP419 description. Adds more tests. Using standard. Renames test
Improve variable name Add comment Minor refactors Improve comments. Minor refactors Improve comments Refactor Add tests for commitFederationAccordingToActivations Remove unnecessary semicolon Refactor to improve testing and readability Add test cases Remove some tests. Make bridge event logger not a mock. Make some methods private instead of protected. Fix log message Improve test name Change test name Move reused method to utility class. Use real block instead of a mock Make methods to be private instead of protected
Add method to utils
Fix sonar complains Add missing import Move method to test class Remove unused imports
…y to bridge storage index key
… to bridge storage provider Remove svp fund tx tests from federation storage provider tests, and adds them to bridge storage provider tests Get rid of sonar complains Add get methods to bridge Put save, set and get tests in same nested class
Add tests. Add missing tests for minimum pegout tx value Modify test
… creating pegouts
Refactor and add test case Add test case Remove mistaken comment Add comment Modify comment
Huge refactor to get rid of duplicated code Minor refactor Minor refactors Renaming, refactors. Add missing test case. Minor fix Reorder, refactor Fix typo, refactor Rename Create private method to get rid of duplicated code Get rid of sonar complains Rename already declared federator keys field. Rename variables to match regular expressions
…tion regtest constants
* feat: first happy path for a peg in * fix: declaration of utxo * fix: black space at the end of the file * fix: assert that the event pegin_btc has been emitted with the correct parameters * feat: replaced mocked feePerKeb constant for an actual instance * fix: now the peg in uses the minimum pegin tx value * fix: moved the method getRskExecutionBlock to BridgeSupoprtTestUtil * fix: using BitcoinTestUtils to make the btcPublicKey generation deterministic * fix: erased extra line * fix: added in BridgeSupportIT an extra line in the end * fix: removed the public modifier in the RegisterBTCTransactionIT * fix: renamed getUtxo to utxoOf
julianlen
force-pushed
the
pegin-tests-integration
branch
from
December 16, 2024 19:29
db3f6bc
to
e0c0cc6
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Quality Gate passedIssues Measures |
marcos-iov
force-pushed
the
feature/powpeg_validation_protocol-phase4
branch
from
January 8, 2025 15:42
27f4e47
to
944b3f3
Compare
Base automatically changed from
feature/powpeg_validation_protocol-phase4
to
feature/powpeg_validation_protocol-integration
January 10, 2025 18:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.